Introduce CurveStyle type for shared STD/TOD styling#16729
Open
kmer2016 wants to merge 1 commit into
Open
Conversation
Output type of the shared curve-style helper. It is computed by the helper and used by STD (PathLayer) and TOD (OccupancyBlockLayer). Signed-off-by: nncluzu <ngamenichaka@yahoo.fr>
Akctarus
reviewed
May 15, 2026
Comment on lines
+144
to
+147
| label?: { | ||
| border?: { color: string; width: number }; | ||
| fontWeight?: number; | ||
| }; |
Contributor
There was a problem hiding this comment.
After working on it, I found out that we better may need something like that for labels:
Suggested change
| label?: { | |
| border?: { color: string; width: number }; | |
| fontWeight?: number; | |
| }; | |
| label?: { | |
| fontWeight?: number; | |
| background?: string; | |
| borderRadius?: number; | |
| }; |
see in #16752 , but it can be discussed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
CurveStyletype to the simulation result types.It is the output of the shared curve-style helper that will style curves in both STD (PathLayer) and TOD (OccupancyBlockLayer).
It is added first so that other developers can start to work on STD, TOD and ui changes in parallel, before the helper itself is ready.